GtkWindow: small cleanup
authorMatthias Clasen <mclasen@redhat.com>
Fri, 9 May 2014 21:13:53 +0000 (17:13 -0400)
committerMatthias Clasen <mclasen@redhat.com>
Fri, 9 May 2014 21:13:53 +0000 (17:13 -0400)
The window type is a construct-only property, so we should
pass it to g_object_new, not set it after the fact in the
constructor.

gtk/gtkwindow.c

index 72c1d35e5fd007658a36275f88967eb34ffb4950..e61d4e127f0cd9320defc2bf7f96c999e4e70246 100644 (file)
@@ -1854,15 +1854,11 @@ gtk_window_buildable_custom_finished (GtkBuildable  *buildable,
 GtkWidget*
 gtk_window_new (GtkWindowType type)
 {
-  GtkWindowPrivate *priv;
   GtkWindow *window;
 
   g_return_val_if_fail (type >= GTK_WINDOW_TOPLEVEL && type <= GTK_WINDOW_POPUP, NULL);
 
-  window = g_object_new (GTK_TYPE_WINDOW, NULL);
-  priv = window->priv;
-
-  priv->type = type;
+  window = g_object_new (GTK_TYPE_WINDOW, "type", type, NULL);
 
   return GTK_WIDGET (window);
 }